|
@@ -3,47 +3,89 @@ From: Kyrylo Hrechykhin <[email protected]>
|
|
|
Date: Thu, 6 Oct 2022 18:30:53 +0200
|
|
|
Subject: fix: on-screen-keyboard hides on input blur in webview
|
|
|
|
|
|
-Changes introduced by this patch fix issue where OSK does not hide on
|
|
|
-input rendered inside webview is blurred. This patch should be removed
|
|
|
-when proper fix in chromium repo is available.
|
|
|
-
|
|
|
-Note: the issue still occurs if input rendered in webview blurred due
|
|
|
-to touch outside of webview. It is caused by webview implementation
|
|
|
-details. Specificaly due to webview has its own tree nodes and focused
|
|
|
-node does not change in this case.
|
|
|
+Work around OSK not hiding by notifying RenderWidgetHostViewAura of
|
|
|
+focus node change via TextInputManager.
|
|
|
|
|
|
chromium-bug: https://crbug.com/1369605
|
|
|
|
|
|
-diff --git a/content/browser/renderer_host/render_widget_host_view_child_frame.cc b/content/browser/renderer_host/render_widget_host_view_child_frame.cc
|
|
|
-index f5f30d5696bdd2b8b5948b18b3f7959f9078cc72..660dc5f60bad28ce345827767fc508711ea06d31 100644
|
|
|
---- a/content/browser/renderer_host/render_widget_host_view_child_frame.cc
|
|
|
-+++ b/content/browser/renderer_host/render_widget_host_view_child_frame.cc
|
|
|
-@@ -1046,6 +1046,12 @@ RenderWidgetHostViewChildFrame::DidUpdateVisualProperties(
|
|
|
- return viz::ScopedSurfaceIdAllocator(std::move(allocation_task));
|
|
|
+diff --git a/content/browser/renderer_host/render_widget_host_view_aura.cc b/content/browser/renderer_host/render_widget_host_view_aura.cc
|
|
|
+index 9840d0e1308bc6e4589f32f6eac5e27f353895dd..366d285bdf5f51a15fd993efba1763cce4461666 100644
|
|
|
+--- a/content/browser/renderer_host/render_widget_host_view_aura.cc
|
|
|
++++ b/content/browser/renderer_host/render_widget_host_view_aura.cc
|
|
|
+@@ -2945,6 +2945,12 @@ void RenderWidgetHostViewAura::OnTextSelectionChanged(
|
|
|
+ }
|
|
|
+ }
|
|
|
+
|
|
|
++void RenderWidgetHostViewAura::OnFocusedInputElementChanged(
|
|
|
++ TextInputManager* text_input_manager,
|
|
|
++ RenderWidgetHostViewBase* view) {
|
|
|
++ FocusedNodeChanged(false, {});
|
|
|
++}
|
|
|
++
|
|
|
+ void RenderWidgetHostViewAura::SetPopupChild(
|
|
|
+ RenderWidgetHostViewAura* popup_child_host_view) {
|
|
|
+ popup_child_host_view_ = popup_child_host_view;
|
|
|
+diff --git a/content/browser/renderer_host/render_widget_host_view_aura.h b/content/browser/renderer_host/render_widget_host_view_aura.h
|
|
|
+index f8a8894f2daddcc6e3c1df6c48645fe8fadeb4b2..da157784415355a2a9f489be96fbbbd333e6afcf 100644
|
|
|
+--- a/content/browser/renderer_host/render_widget_host_view_aura.h
|
|
|
++++ b/content/browser/renderer_host/render_widget_host_view_aura.h
|
|
|
+@@ -628,6 +628,8 @@ class CONTENT_EXPORT RenderWidgetHostViewAura
|
|
|
+ RenderWidgetHostViewBase* updated_view) override;
|
|
|
+ void OnTextSelectionChanged(TextInputManager* text_input_mangager,
|
|
|
+ RenderWidgetHostViewBase* updated_view) override;
|
|
|
++ void OnFocusedInputElementChanged(TextInputManager* text_input_manager,
|
|
|
++ RenderWidgetHostViewBase* view) override;
|
|
|
+
|
|
|
+ // Detaches |this| from the input method object.
|
|
|
+ // is_removed flag is true if this is called while the window is
|
|
|
+diff --git a/content/browser/renderer_host/text_input_manager.cc b/content/browser/renderer_host/text_input_manager.cc
|
|
|
+index 6c4403063fd5a57ea1d8ff3446ba74ea10090e5a..269830964194ca8fae6b3bd11d2955ab3e8ab782 100644
|
|
|
+--- a/content/browser/renderer_host/text_input_manager.cc
|
|
|
++++ b/content/browser/renderer_host/text_input_manager.cc
|
|
|
+@@ -167,6 +167,7 @@ void TextInputManager::UpdateTextInputState(
|
|
|
+
|
|
|
+ if (text_input_state.type == ui::TEXT_INPUT_TYPE_NONE &&
|
|
|
+ active_view_ != view) {
|
|
|
++ NotifyFocusedInputElementChanged(active_view_);
|
|
|
+ // We reached here because an IPC is received to reset the TextInputState
|
|
|
+ // for |view|. But |view| != |active_view_|, which suggests that at least
|
|
|
+ // one other view has become active and we have received the corresponding
|
|
|
+@@ -453,6 +454,12 @@ void TextInputManager::NotifyObserversAboutInputStateUpdate(
|
|
|
+ observer.OnUpdateTextInputStateCalled(this, updated_view, did_update_state);
|
|
|
}
|
|
|
|
|
|
-+void RenderWidgetHostViewChildFrame::FocusedNodeChanged(
|
|
|
-+ bool is_editable_node,
|
|
|
-+ const gfx::Rect& node_bounds_in_screen) {
|
|
|
-+ NOTREACHED();
|
|
|
++void TextInputManager::NotifyFocusedInputElementChanged(
|
|
|
++ RenderWidgetHostViewBase* view) {
|
|
|
++ for (auto& observer : observer_list_)
|
|
|
++ observer.OnFocusedInputElementChanged(this, view);
|
|
|
+}
|
|
|
+
|
|
|
- ui::TextInputType RenderWidgetHostViewChildFrame::GetTextInputType() const {
|
|
|
- if (!text_input_manager_)
|
|
|
- return ui::TEXT_INPUT_TYPE_NONE;
|
|
|
-diff --git a/content/browser/renderer_host/render_widget_host_view_child_frame.h b/content/browser/renderer_host/render_widget_host_view_child_frame.h
|
|
|
-index 1dfd9c071a41482e0d35257b28522e5b37702f25..41a09e9470dfa5797c69d02fc9b4f5e608a43d94 100644
|
|
|
---- a/content/browser/renderer_host/render_widget_host_view_child_frame.h
|
|
|
-+++ b/content/browser/renderer_host/render_widget_host_view_child_frame.h
|
|
|
-@@ -184,6 +184,8 @@ class CONTENT_EXPORT RenderWidgetHostViewChildFrame
|
|
|
- void DisableAutoResize(const gfx::Size& new_size) override;
|
|
|
- viz::ScopedSurfaceIdAllocator DidUpdateVisualProperties(
|
|
|
- const cc::RenderFrameMetadata& metadata) override;
|
|
|
-+ void FocusedNodeChanged(bool is_editable_node,
|
|
|
-+ const gfx::Rect& node_bounds_in_screen) override;
|
|
|
-
|
|
|
- // RenderFrameMetadataProvider::Observer implementation.
|
|
|
- void OnRenderFrameMetadataChangedBeforeActivation(
|
|
|
+ TextInputManager::SelectionRegion::SelectionRegion() = default;
|
|
|
+
|
|
|
+ TextInputManager::SelectionRegion::SelectionRegion(
|
|
|
+diff --git a/content/browser/renderer_host/text_input_manager.h b/content/browser/renderer_host/text_input_manager.h
|
|
|
+index 35d0355b0e181ecf38146a70559eb6070e83d6d6..47d37b5f7c9a62e1b7c91de5bd0d0d562795bc89 100644
|
|
|
+--- a/content/browser/renderer_host/text_input_manager.h
|
|
|
++++ b/content/browser/renderer_host/text_input_manager.h
|
|
|
+@@ -71,6 +71,10 @@ class CONTENT_EXPORT TextInputManager {
|
|
|
+ virtual void OnTextSelectionChanged(
|
|
|
+ TextInputManager* text_input_manager,
|
|
|
+ RenderWidgetHostViewBase* updated_view) {}
|
|
|
++ // Called when focused input element has changed
|
|
|
++ virtual void OnFocusedInputElementChanged(
|
|
|
++ TextInputManager* text_input_manager,
|
|
|
++ RenderWidgetHostViewBase* updated_view) {}
|
|
|
+ };
|
|
|
+
|
|
|
+ // Text selection bounds.
|
|
|
+@@ -278,6 +282,7 @@ class CONTENT_EXPORT TextInputManager {
|
|
|
+
|
|
|
+ void NotifyObserversAboutInputStateUpdate(RenderWidgetHostViewBase* view,
|
|
|
+ bool did_update_state);
|
|
|
++ void NotifyFocusedInputElementChanged(RenderWidgetHostViewBase* view);
|
|
|
+
|
|
|
+ // The view with active text input state, i.e., a focused <input> element.
|
|
|
+ // It will be nullptr if no such view exists. Note that the active view
|
|
|
diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc
|
|
|
index 5f7f36a4b77fda73dc77cde23a8671c89a1f2b78..3ade9312a09494dece3935cc87c56bf464d28399 100644
|
|
|
--- a/content/browser/web_contents/web_contents_impl.cc
|