Browse Source

fix: -Wunsafe-buffer-usage warning in asar_util's ReadFileToString() (#43896)

Charles Kerr 6 months ago
parent
commit
500d4f0d05
1 changed files with 1 additions and 4 deletions
  1. 1 4
      shell/common/asar/asar_util.cc

+ 1 - 4
shell/common/asar/asar_util.cc

@@ -126,11 +126,8 @@ bool ReadFileToString(const base::FilePath& path, std::string* contents) {
     return false;
 
   contents->resize(info.size);
-  if (static_cast<int>(info.size) !=
-      src.Read(info.offset, const_cast<char*>(contents->data()),
-               contents->size())) {
+  if (!src.ReadAndCheck(info.offset, base::as_writable_byte_span(*contents)))
     return false;
-  }
 
   if (info.integrity)
     ValidateIntegrityOrDie(base::as_byte_span(*contents), *info.integrity);