Browse Source

fix: Node.js cpu and heap profiling (#24541)

* fix: Node.js cpu and heap profiling

* chore: emable more now-working Node.js specs
Shelley Vohr 4 years ago
parent
commit
4e202b8bd0
2 changed files with 3 additions and 15 deletions
  1. 0 15
      script/node-disabled-tests.json
  2. 3 0
      shell/browser/node_debugger.cc

+ 0 - 15
script/node-disabled-tests.json

@@ -99,8 +99,6 @@
   "parallel/test-module-version",
   "parallel/test-openssl-ca-options",
   "parallel/test-policy-integrity",
-  "parallel/test-preload",
-  "parallel/test-preload-print-process-argv",
   "parallel/test-process-env-allowed-flags-are-documented",
   "parallel/test-process-env-sideeffects",
   "parallel/test-process-exception-capture",
@@ -219,22 +217,9 @@
   "sequential/test-cli-syntax-bad",
   "sequential/test-cli-syntax-good",
   "sequential/test-cli-syntax-require",
-  "sequential/test-cpu-prof-default",
-  "sequential/test-cpu-prof-dir-absolute",
-  "sequential/test-cpu-prof-dir-and-name",
-  "sequential/test-cpu-prof-dir-relative",
-  "sequential/test-cpu-prof-dir-worker",
-  "sequential/test-cpu-prof-drained",
-  "sequential/test-cpu-prof-exit",
-  "sequential/test-cpu-prof-invalid-options",
-  "sequential/test-cpu-prof-kill",
-  "sequential/test-cpu-prof-name",
-  "sequential/test-cpu-prof-worker-argv",
   "sequential/test-deprecation-flags",
   "sequential/test-fs-watch",
-  "sequential/test-heap-prof",
   "sequential/test-heapdump",
-  "sequential/test-heapdump-flag",
   "sequential/test-inspector-contexts",
   "sequential/test-inspector-port-zero",
   "sequential/test-inspector-resource-name-to-url",

+ 3 - 0
shell/browser/node_debugger.cc

@@ -57,6 +57,9 @@ void NodeDebugger::Start() {
                        true /* is_main */))
     DCHECK(inspector->IsListening());
 
+  v8::HandleScope handle_scope(env_->isolate());
+  node::profiler::StartProfilers(env_);
+
   if (inspector->options().break_node_first_line) {
     inspector->PauseOnNextJavascriptStatement("Break at bootstrap");
   }