Browse Source

chore: bump chromium to 89.0.4389.128 (12-x-y) (#28659)

* chore: bump chromium in DEPS to 89.0.4389.128

* update patches
Electron Bot 4 years ago
parent
commit
4de3e451ac
3 changed files with 1 additions and 91 deletions
  1. 1 1
      DEPS
  2. 0 1
      patches/v8/.patches
  3. 0 89
      patches/v8/cherry-pick-02f84c745fc0.patch

+ 1 - 1
DEPS

@@ -14,7 +14,7 @@ gclient_gn_args = [
 
 vars = {
   'chromium_version':
-    '89.0.4389.114',
+    '89.0.4389.128',
   'node_version':
     'v14.16.0',
   'nan_version':

+ 0 - 1
patches/v8/.patches

@@ -11,4 +11,3 @@ fix_use_proper_page_size_for_mac_arm64.patch
 chore_disallow_copying_cppheapcreateparams.patch
 mac_wasm_work_around_macos_11_2_code_page_decommit_failures.patch
 patch_profiler_allow_empty_source_url_for_asm_modules.patch
-cherry-pick-02f84c745fc0.patch

+ 0 - 89
patches/v8/cherry-pick-02f84c745fc0.patch

@@ -1,89 +0,0 @@
-From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
-From: Georg Neis <[email protected]>
-Date: Mon, 12 Apr 2021 09:42:03 +0200
-Subject: Fix bug in InstructionSelector::ChangeInt32ToInt64
-
-Bug: chromium:1196683
-Change-Id: Ib4ea738b47b64edc81450583be4c80a41698c3d1
-Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2820971
-Commit-Queue: Georg Neis <[email protected]>
-Reviewed-by: Nico Hartmann <[email protected]>
-Cr-Commit-Position: refs/heads/master@{#73903}
-
-diff --git a/src/compiler/backend/x64/instruction-selector-x64.cc b/src/compiler/backend/x64/instruction-selector-x64.cc
-index e2d8cf27bfcd5b09bf823a5f9b33dd4cad683295..79b549f01c66fd0c9bea8f9c553c8f5f7afbeb79 100644
---- a/src/compiler/backend/x64/instruction-selector-x64.cc
-+++ b/src/compiler/backend/x64/instruction-selector-x64.cc
-@@ -1370,7 +1370,9 @@ void InstructionSelector::VisitChangeInt32ToInt64(Node* node) {
-         opcode = load_rep.IsSigned() ? kX64Movsxwq : kX64Movzxwq;
-         break;
-       case MachineRepresentation::kWord32:
--        opcode = load_rep.IsSigned() ? kX64Movsxlq : kX64Movl;
-+        // ChangeInt32ToInt64 must interpret its input as a _signed_ 32-bit
-+        // integer, so here we must sign-extend the loaded value in any case.
-+        opcode = kX64Movsxlq;
-         break;
-       default:
-         UNREACHABLE();
-diff --git a/test/mjsunit/compiler/regress-1196683.js b/test/mjsunit/compiler/regress-1196683.js
-new file mode 100644
-index 0000000000000000000000000000000000000000..abd7d6b2f8da45991e1e3b6c72582bc716d63efb
---- /dev/null
-+++ b/test/mjsunit/compiler/regress-1196683.js
-@@ -0,0 +1,56 @@
-+// Copyright 2021 the V8 project authors. All rights reserved.
-+// Use of this source code is governed by a BSD-style license that can be
-+// found in the LICENSE file.
-+
-+// Flags: --allow-natives-syntax
-+
-+
-+(function() {
-+  const arr = new Uint32Array([2**31]);
-+  function foo() {
-+    return (arr[0] ^ 0) + 1;
-+  }
-+  %PrepareFunctionForOptimization(foo);
-+  assertEquals(-(2**31) + 1, foo());
-+  %OptimizeFunctionOnNextCall(foo);
-+  assertEquals(-(2**31) + 1, foo());
-+});
-+
-+
-+// The remaining tests already passed without the bugfix.
-+
-+
-+(function() {
-+  const arr = new Uint16Array([2**15]);
-+  function foo() {
-+    return (arr[0] ^ 0) + 1;
-+  }
-+  %PrepareFunctionForOptimization(foo);
-+  assertEquals(2**15 + 1, foo());
-+  %OptimizeFunctionOnNextCall(foo);
-+  assertEquals(2**15 + 1, foo());
-+})();
-+
-+
-+(function() {
-+  const arr = new Uint8Array([2**7]);
-+  function foo() {
-+    return (arr[0] ^ 0) + 1;
-+  }
-+  %PrepareFunctionForOptimization(foo);
-+  assertEquals(2**7 + 1, foo());
-+  %OptimizeFunctionOnNextCall(foo);
-+  assertEquals(2**7 + 1, foo());
-+})();
-+
-+
-+(function() {
-+  const arr = new Int32Array([-(2**31)]);
-+  function foo() {
-+    return (arr[0] >>> 0) + 1;
-+  }
-+  %PrepareFunctionForOptimization(foo);
-+  assertEquals(2**31 + 1, foo());
-+  %OptimizeFunctionOnNextCall(foo);
-+  assertEquals(2**31 + 1, foo());
-+})();