Browse Source

refactor: use locale functions in command_line_args.cc (#29550)

This change refactors the code to use isalpha() and
isspace() so that the code is more readable.

Signed-off-by: Darshan Sen <[email protected]>
Darshan Sen 3 years ago
parent
commit
4b9e804b82
1 changed files with 3 additions and 2 deletions
  1. 3 2
      shell/app/command_line_args.cc

+ 3 - 2
shell/app/command_line_args.cc

@@ -3,13 +3,14 @@
 // found in the LICENSE file.
 
 #include "shell/app/command_line_args.h"
+#include <locale>
 
 namespace {
 
 bool IsUrlArg(const base::CommandLine::CharType* arg) {
   // the first character must be a letter for this to be a URL
   auto c = *arg;
-  if (('a' <= c && c <= 'z') || ('A' <= c && c <= 'Z')) {
+  if (std::isalpha(c, std::locale::classic())) {
     for (auto* p = arg + 1; *p; ++p) {
       c = *p;
 
@@ -23,7 +24,7 @@ bool IsUrlArg(const base::CommandLine::CharType* arg) {
       }
 
       // white-space before a colon means it's not a URL
-      if (c == ' ' || (0x9 <= c && c <= 0xD))
+      if (std::isspace(c, std::locale::classic()))
         break;
     }
   }