Browse Source

remove appcommand media-play_pause option deprecation

Shelley Vohr 7 years ago
parent
commit
3deffa859d
2 changed files with 0 additions and 17 deletions
  1. 0 4
      atom/browser/native_window_views_win.cc
  2. 0 13
      docs/tutorial/planned-breaking-changes.md

+ 0 - 4
atom/browser/native_window_views_win.cc

@@ -143,10 +143,6 @@ bool NativeWindowViews::ExecuteWindowsCommand(int command_id) {
   std::string command = AppCommandToString(command_id);
   NotifyWindowExecuteWindowsCommand(command);
 
-  if (command_id == APPCOMMAND_MEDIA_PLAY_PAUSE)
-    // FIXME(htk3): Remove media-play_pause in 3.0
-    NotifyWindowExecuteWindowsCommand("media-play_pause");
-
   return false;
 }
 

+ 0 - 13
docs/tutorial/planned-breaking-changes.md

@@ -14,19 +14,6 @@ let windowA = new BrowserWindow(optionsA)
 // Replace with
 let optionsB = {webPreferences: {enableBlinkFeatures: ''}}
 let windowB = new BrowserWindow(optionsB)
-
-// Deprecated
-window.on('app-command', (e, cmd) => {
-  if (cmd === 'media-play_pause') {
-    // do something
-  }
-})
-// Replace with
-window.on('app-command', (e, cmd) => {
-  if (cmd === 'media-play-pause') {
-    // do something
-  }
-})
 ```
 
 ## `nativeImage`