Browse Source

win: Fix dumping symbols.

Cheng Zhao 11 years ago
parent
commit
3c0ec73d75
2 changed files with 10 additions and 3 deletions
  1. 9 0
      script/bootstrap.py
  2. 1 3
      tools/win/generate_breakpad_symbols.py

+ 9 - 0
script/bootstrap.py

@@ -25,6 +25,8 @@ def main():
   bootstrap_brightray(args.url)
   if sys.platform == 'cygwin':
     update_win32_python()
+  if sys.platform in ['win32', 'cygwin']:
+    install_runas()
 
   touch_config_gypi()
   update_atom_shell()
@@ -72,6 +74,13 @@ def update_win32_python():
       execute(['git', 'clone', PYTHON_26_URL])
 
 
+def install_runas():
+  # TODO This is needed by the tools/win/register_msdia80_dll.js, should move
+  # this to a better place.
+  with scoped_cwd(os.path.join(SOURCE_ROOT, 'tools', 'win')):
+    execute([NPM, 'install', 'runas'])
+
+
 def touch_config_gypi():
   config_gypi = os.path.join(SOURCE_ROOT, 'vendor', 'node', 'config.gypi')
   with open(config_gypi, 'w+') as f:

+ 1 - 3
tools/win/generate_breakpad_symbols.py

@@ -49,9 +49,7 @@ def mkdir_p(path):
 
 def RegisterRequiredDll():
   register = os.path.join(os.path.dirname(__file__), 'register_msdia80_dll.js')
-  node = os.path.join(SOURCE_ROOT, 'out', 'Release', 'atom.exe')
-  os.environ['ATOM_SHELL_INTERNAL_RUN_AS_NODE'] = '1'
-  subprocess.check_call([node, register]);
+  subprocess.check_call(['node.exe', register]);
 
 
 def GenerateSymbols(options, binaries):