Browse Source

test: use emittedUntil in PDF Viewer tests (#27248)

Milan Burda 4 years ago
parent
commit
36f4ee87df
1 changed files with 7 additions and 5 deletions
  1. 7 5
      spec-main/chromium-spec.ts

+ 7 - 5
spec-main/chromium-spec.ts

@@ -1,6 +1,6 @@
 import { expect } from 'chai';
 import { BrowserWindow, WebContents, session, ipcMain, app, protocol, webContents } from 'electron/main';
-import { emittedOnce } from './events-helpers';
+import { emittedOnce, emittedUntil } from './events-helpers';
 import { closeAllWindows } from './window-helpers';
 import * as https from 'https';
 import * as http from 'http';
@@ -1283,15 +1283,17 @@ describe('chromium features', () => {
     it('opens when loading a pdf resource as top level navigation', async () => {
       const w = new BrowserWindow({ show: false });
       w.loadURL(pdfSource);
-      const [, contents] = await emittedOnce(app, 'web-contents-created');
-      expect(contents.getURL()).to.equal('chrome-extension://mhjfbmdgcfjbbpaeojofohoefgiehjai/index.html');
+      await emittedUntil(app, 'web-contents-created', (event: Electron.Event, contents: WebContents) => {
+        return contents.getURL() === 'chrome-extension://mhjfbmdgcfjbbpaeojofohoefgiehjai/index.html';
+      });
     });
 
     it('opens when loading a pdf resource in a iframe', async () => {
       const w = new BrowserWindow({ show: false });
       w.loadFile(path.join(__dirname, 'fixtures', 'pages', 'pdf-in-iframe.html'));
-      const [, contents] = await emittedOnce(app, 'web-contents-created');
-      expect(contents.getURL()).to.equal('chrome-extension://mhjfbmdgcfjbbpaeojofohoefgiehjai/index.html');
+      await emittedUntil(app, 'web-contents-created', (event: Electron.Event, contents: WebContents) => {
+        return contents.getURL() === 'chrome-extension://mhjfbmdgcfjbbpaeojofohoefgiehjai/index.html';
+      });
     });
   });