Home Explore 引导页 在线工具 Blog
Register Sign In
Pchen0
/
electron
1
0
Fork 0
Files Issues 0 Pull Requests 0 Wiki
Browse Source

Read window size properly in `window.open` test

`BrowserWindow#getSize` returns `[width, height]`, not `{width, height}`.
Jeff Wear 9 years ago
parent
4252c17db0
commit
32e949efed
2 changed files with 3 additions and 3 deletions
Split View Show Diff Stats
  1. 2 2
      spec/chromium-spec.coffee
  2. 1 1
      spec/fixtures/pages/window-open-size.html

+ 2 - 2
spec/chromium-spec.coffee
View File 

@@ -75,8 +75,8 @@ describe 'chromium feature', ->
 
 
     it 'inherit options of parent window', (done) ->
 
       listener = (event) ->
 
-        size = remote.getCurrentWindow().getSize()
 
-        assert.equal event.data, "size: #{size.width} #{size.height}"
 
+        [width, height] = remote.getCurrentWindow().getSize()
 
+        assert.equal event.data, "size: #{width} #{height}"
 
         b.close()
 
         done()
 
       window.addEventListener 'message', listener

+ 1 - 1
spec/fixtures/pages/window-open-size.html
View File 

@@ -2,7 +2,7 @@
 
 <body>
 
 <script type="text/javascript" charset="utf-8">
 
   var size = require('electron').remote.getCurrentWindow().getSize();
 
-  window.opener.postMessage('size: ' + size.width + ' ' + size.height, '*')
 
+  window.opener.postMessage('size: ' + size[0] + ' ' + size[1], '*')
 
 </script>
 
 </body>
 
 </html>