Browse Source

fix: param passed to `showSaveDialogSync` on Linux (#42652)

fix: pass correct param to sync functions on Linux
Shelley Vohr 9 months ago
parent
commit
2b31d8459d
1 changed files with 1 additions and 7 deletions
  1. 1 7
      shell/browser/ui/file_dialog_linux.cc

+ 1 - 7
shell/browser/ui/file_dialog_linux.cc

@@ -208,9 +208,6 @@ class FileChooserDialog : public ui::SelectFileDialog::Listener {
 
 bool ShowOpenDialogSync(const DialogSettings& settings,
                         std::vector<base::FilePath>* paths) {
-  v8::Isolate* isolate = electron::JavascriptEnvironment::GetIsolate();
-  gin_helper::Promise<gin_helper::Dictionary> promise(isolate);
-
   base::RunLoop run_loop(base::RunLoop::Type::kNestableTasksAllowed);
   auto cb = base::BindOnce(
       [](base::RepeatingClosure cb, std::vector<base::FilePath>* file_paths,
@@ -222,7 +219,6 @@ bool ShowOpenDialogSync(const DialogSettings& settings,
 
   FileChooserDialog* dialog = new FileChooserDialog();
   dialog->RunOpenDialog(std::move(cb), settings);
-
   run_loop.Run();
   return !paths->empty();
 }
@@ -235,8 +231,6 @@ void ShowOpenDialog(const DialogSettings& settings,
 
 bool ShowSaveDialogSync(const DialogSettings& settings, base::FilePath* path) {
   base::RunLoop run_loop(base::RunLoop::Type::kNestableTasksAllowed);
-  v8::Isolate* isolate = electron::JavascriptEnvironment::GetIsolate();
-  gin_helper::Promise<gin_helper::Dictionary> promise(isolate);
   auto cb = base::BindOnce(
       [](base::RepeatingClosure cb, base::FilePath* file_path,
          gin_helper::Dictionary result) {
@@ -246,7 +240,7 @@ bool ShowSaveDialogSync(const DialogSettings& settings, base::FilePath* path) {
       run_loop.QuitClosure(), path);
 
   FileChooserDialog* dialog = new FileChooserDialog();
-  dialog->RunSaveDialog(std::move(promise), settings);
+  dialog->RunSaveDialog(std::move(cb), settings);
   run_loop.Run();
   return !path->empty();
 }