Browse Source

fix: defaults broken in shell.openExternal() options (#38092)

fix: defaults broken in shell.openExternal() options (#38038)

Co-authored-by: Milan Burda <[email protected]>
Milan Burda 2 years ago
parent
commit
27575566c9
1 changed files with 4 additions and 6 deletions
  1. 4 6
      shell/common/api/electron_api_shell.cc

+ 4 - 6
shell/common/api/electron_api_shell.cc

@@ -59,12 +59,10 @@ v8::Local<v8::Promise> OpenExternal(const GURL& url, gin::Arguments* args) {
   v8::Local<v8::Promise> handle = promise.GetHandle();
 
   platform_util::OpenExternalOptions options;
-  if (args->Length() >= 2) {
-    gin::Dictionary obj(nullptr);
-    if (args->GetNext(&obj)) {
-      obj.Get("activate", &options.activate);
-      obj.Get("workingDirectory", &options.working_dir);
-    }
+  gin_helper::Dictionary obj;
+  if (args->GetNext(&obj)) {
+    obj.Get("activate", &options.activate);
+    obj.Get("workingDirectory", &options.working_dir);
   }
 
   platform_util::OpenExternal(