Browse Source

update signature for setCertificateVerifyProc in session spec

Shelley Vohr 6 years ago
parent
commit
2660859434
2 changed files with 5 additions and 5 deletions
  1. 2 2
      spec/api-session-spec.js
  2. 3 3
      spec/security-warnings-spec.js

+ 2 - 2
spec/api-session-spec.js

@@ -589,7 +589,7 @@ describe('session module', () => {
 
     describe('deprecated function signature', () => {
       it('supports accepting the request', (done) => {
-        session.defaultSession.setCertificateVerifyProc((hostname, certificate, callback) => {
+        session.defaultSession.setCertificateVerifyProc(({hostname, certificate}, callback) => {
           assert.equal(hostname, '127.0.0.1')
           callback(true)
         })
@@ -602,7 +602,7 @@ describe('session module', () => {
       })
 
       it('supports rejecting the request', (done) => {
-        session.defaultSession.setCertificateVerifyProc((hostname, certificate, callback) => {
+        session.defaultSession.setCertificateVerifyProc(({hostname, certificate}, callback) => {
           assert.equal(hostname, '127.0.0.1')
           callback(false)
         })

+ 3 - 3
spec/security-warnings-spec.js

@@ -133,16 +133,16 @@ describe('security warnings', () => {
     w.loadURL(`http://127.0.0.1:8881/base-page-security.html`)
   })
 
-  it('should warn about blinkFeatures', (done) => {
+  it('should warn about enableBlinkFeatures', (done) => {
     w = new BrowserWindow({
       show: false,
       webPreferences: {
-        blinkFeatures: ['my-cool-feature'],
+        enableBlinkFeatures: ['my-cool-feature'],
         nodeIntegration: false
       }
     })
     w.webContents.once('console-message', (e, level, message) => {
-      assert(message.includes('blinkFeatures'), message)
+      assert(message.includes('enableBlinkFeatures'), message)
       done()
     })