Browse Source

chore: remove deprecated app.enableMixedSandbox() (#17894)

Milan Burda 6 years ago
parent
commit
253d049ac9
3 changed files with 15 additions and 4 deletions
  1. 9 0
      docs/api/breaking-changes.md
  2. 5 0
      docs/api/chrome-command-line-switches.md
  3. 1 4
      lib/browser/api/app.ts

+ 9 - 0
docs/api/breaking-changes.md

@@ -81,6 +81,15 @@ powerMonitor.querySystemIdleTime(callback)
 const idleTime = getSystemIdleTime()
 ```
 
+## `app.enableMixedSandbox`
+
+```js
+// Deprecated
+app.enableMixedSandbox()
+```
+
+Mixed-sandbox mode is now enabled by default.
+
 ## Preload scripts outside of app path are not allowed
 
 For security reasons, preload scripts can only be loaded from a subpath of the [app path](app.md#appgetapppath).

+ 5 - 0
docs/api/chrome-command-line-switches.md

@@ -181,6 +181,11 @@ logging level for all code in the source files under a `foo/bar` directory.
 
 This switch only works when `--enable-logging` is also passed.
 
+## --no-sandbox
+
+Disables Chromium sandbox, which is now enabled by default.
+Should only be used for testing.
+
 [app]: app.md
 [append-switch]: app.md#appcommandlineappendswitchswitch-value
 [ready]: app.md#event-ready

+ 1 - 4
lib/browser/api/app.ts

@@ -32,10 +32,7 @@ Object.assign(app, {
     getSwitchValue: (theSwitch: string) => commandLine.getSwitchValue(String(theSwitch)),
     appendSwitch: (theSwitch: string, value?: string) => commandLine.appendSwitch(String(theSwitch), typeof value === 'undefined' ? value : String(value)),
     appendArgument: (arg: string) => commandLine.appendArgument(String(arg))
-  } as Electron.CommandLine,
-  enableMixedSandbox () {
-    deprecate.log(`'enableMixedSandbox' is deprecated. Mixed-sandbox mode is now enabled by default. You can safely remove the call to enableMixedSandbox().`)
-  }
+  } as Electron.CommandLine
 })
 
 // we define this here because it'd be overly complicated to