Browse Source

Default async to false when object is specified

Kevin Sawicki 8 years ago
parent
commit
23b235c9c7
1 changed files with 4 additions and 1 deletions
  1. 4 1
      lib/browser/api/menu.js

+ 4 - 1
lib/browser/api/menu.js

@@ -144,7 +144,7 @@ Menu.prototype._init = function () {
 }
 
 Menu.prototype.popup = function (window, x, y, positioningItem) {
-  let asyncPopup = false
+  let asyncPopup
 
   // menu.popup(x, y, positioningItem)
   if (window != null && (typeof window !== 'object' || window.constructor !== BrowserWindow)) {
@@ -174,6 +174,9 @@ Menu.prototype.popup = function (window, x, y, positioningItem) {
   // Default to not highlighting any item.
   if (typeof positioningItem !== 'number') positioningItem = -1
 
+  // Default to synchronous for backwards compatibility.
+  if (typeof asyncPopup !== 'boolean') asyncPopup = false
+
   this.popupAt(window, x, y, positioningItem, asyncPopup)
 }