Browse Source

fix: use isEqual instead of pointer equality to convert NSAppearance (#18690)

trop[bot] 5 years ago
parent
commit
21f033474d
1 changed files with 2 additions and 2 deletions
  1. 2 2
      atom/browser/api/atom_api_system_preferences_mac.mm

+ 2 - 2
atom/browser/api/atom_api_system_preferences_mac.mm

@@ -62,11 +62,11 @@ struct Converter<NSAppearance*> {
       return v8::Null(isolate);
     }
 
-    if (val.name == NSAppearanceNameAqua) {
+    if ([val.name isEqualToString:NSAppearanceNameAqua]) {
       return mate::ConvertToV8(isolate, "light");
     }
     if (@available(macOS 10.14, *)) {
-      if (val.name == NSAppearanceNameDarkAqua) {
+      if ([val.name isEqualToString:NSAppearanceNameDarkAqua]) {
         return mate::ConvertToV8(isolate, "dark");
       }
     }