Browse Source

Don't resolve empty src/preload attribute values

Kevin Sawicki 8 years ago
parent
commit
1dbaf4987e
2 changed files with 9 additions and 0 deletions
  1. 1 0
      lib/renderer/web-view/web-view-attributes.js
  2. 8 0
      spec/webview-spec.js

+ 1 - 0
lib/renderer/web-view/web-view-attributes.js

@@ -9,6 +9,7 @@ const remote = require('electron').remote
 var a = document.createElement('a')
 
 var resolveURL = function (url) {
+  if (url === '') return ''
   a.href = url
   return a.href
 }

+ 8 - 0
spec/webview-spec.js

@@ -80,6 +80,10 @@ describe('<webview> tag', function () {
       assert.equal(webview.src, '')
       webview.src = ''
       assert.equal(webview.src, '')
+      webview.src = null
+      assert.equal(webview.src, '')
+      webview.src = undefined
+      assert.equal(webview.src, '')
     })
   })
 
@@ -209,6 +213,10 @@ describe('<webview> tag', function () {
       assert.equal(webview.preload, '')
       webview.preload = ''
       assert.equal(webview.preload, '')
+      webview.preload = null
+      assert.equal(webview.preload, '')
+      webview.preload = undefined
+      assert.equal(webview.preload, '')
     })
   })