Browse Source

Don't use this.skip() since after hooks won't be run

Kevin Sawicki 8 years ago
parent
commit
1afa41477d
2 changed files with 4 additions and 4 deletions
  1. 3 3
      spec/api-browser-window-spec.js
  2. 1 1
      spec/api-clipboard-spec.js

+ 3 - 3
spec/api-browser-window-spec.js

@@ -523,7 +523,7 @@ describe('browser-window module', function () {
 
   describe('BrowserWindow.setAppDetails(options)', function () {
     it('supports setting the app details', function () {
-      if (process.platform !== 'win32') return this.skip()
+      if (process.platform !== 'win32') return
 
       const iconPath = path.join(fixtures, 'assets', 'icon.ico')
 
@@ -660,7 +660,7 @@ describe('browser-window module', function () {
 
   describe('"zoomToPageWidth" option', function () {
     it('sets the window width to the page width when used', function () {
-      if (process.platform !== 'darwin') return this.skip()
+      if (process.platform !== 'darwin') return
 
       w.destroy()
       w = new BrowserWindow({
@@ -1723,7 +1723,7 @@ describe('browser-window module', function () {
 
   describe('previewFile', function () {
     it('opens the path in Quick Look on macOS', function () {
-      if (process.platform !== 'darwin') return this.skip()
+      if (process.platform !== 'darwin') return
 
       assert.doesNotThrow(function () {
         w.previewFile(__filename)

+ 1 - 1
spec/api-clipboard-spec.js

@@ -87,7 +87,7 @@ describe('clipboard module', function () {
 
   describe('clipboard.read/writeFindText(text)', function () {
     it('reads and write text to the find pasteboard', function () {
-      if (process.platform !== 'darwin') return this.skip()
+      if (process.platform !== 'darwin') return
 
       clipboard.writeFindText('find this')
       assert.equal(clipboard.readFindText(), 'find this')