Browse Source

test: do not trigger unhandled promise rejections (#22922)

Cheng Zhao 5 years ago
parent
commit
14051ff945
1 changed files with 9 additions and 7 deletions
  1. 9 7
      spec-main/api-web-request-spec.ts

+ 9 - 7
spec-main/api-web-request-spec.ts

@@ -135,16 +135,16 @@ describe('webRequest module', () => {
       await ajax(defaultURL + 'serverRedirect');
     });
 
-    it('works with file:// protocol', (done) => {
+    it('works with file:// protocol', async () => {
       ses.webRequest.onBeforeRequest((details, callback) => {
         callback({ cancel: true });
-        done();
       });
-      ajax(url.format({
+      const fileURL = url.format({
         pathname: path.join(fixturesPath, 'blank.html').replace(/\\/g, '/'),
         protocol: 'file',
         slashes: true
-      }));
+      });
+      await expect(ajax(fileURL)).to.eventually.be.rejectedWith('404');
     });
   });
 
@@ -207,22 +207,24 @@ describe('webRequest module', () => {
       await ajax(defaultURL);
     });
 
-    it('works with file:// protocol', (done) => {
+    it('works with file:// protocol', async () => {
       const requestHeaders = {
         Test: 'header'
       };
+      let onSendHeadersCalled = false;
       ses.webRequest.onBeforeSendHeaders((details, callback) => {
         callback({ requestHeaders: requestHeaders });
       });
       ses.webRequest.onSendHeaders((details) => {
         expect(details.requestHeaders).to.deep.equal(requestHeaders);
-        done();
+        onSendHeadersCalled = true;
       });
-      ajax(url.format({
+      await ajax(url.format({
         pathname: path.join(fixturesPath, 'blank.html').replace(/\\/g, '/'),
         protocol: 'file',
         slashes: true
       }));
+      expect(onSendHeadersCalled).to.be.true();
     });
   });