Browse Source

fix: improve ses.cookies.set error message when url is missing (#26268)

Jeremy Rose 4 years ago
parent
commit
123e8d7038
1 changed files with 3 additions and 0 deletions
  1. 3 0
      shell/browser/api/electron_api_cookies.cc

+ 3 - 0
shell/browser/api/electron_api_cookies.cc

@@ -291,6 +291,9 @@ v8::Local<v8::Promise> Cookies::Set(v8::Isolate* isolate,
   v8::Local<v8::Promise> handle = promise.GetHandle();
 
   const std::string* url_string = details.FindStringKey("url");
+  if (!url_string) {
+    promise.RejectWithErrorMessage("Missing required option 'url'");
+  }
   const std::string* name = details.FindStringKey("name");
   const std::string* value = details.FindStringKey("value");
   const std::string* domain = details.FindStringKey("domain");