Browse Source

fix: report more detailed errors in shell.openExternal() on Windows (#33660)

Co-authored-by: Milan Burda <[email protected]>
trop[bot] 3 years ago
parent
commit
11e14081cf
1 changed files with 2 additions and 1 deletions
  1. 2 1
      shell/common/platform_util_win.cc

+ 2 - 1
shell/common/platform_util_win.cc

@@ -251,7 +251,8 @@ std::string OpenExternalOnWorkerThread(
           ShellExecuteW(nullptr, L"open", escaped_url.c_str(), nullptr,
                         working_dir.empty() ? nullptr : working_dir.c_str(),
                         SW_SHOWNORMAL)) <= 32) {
-    return "Failed to open";
+    return "Failed to open: " +
+           logging::SystemErrorCodeToString(logging::GetLastSystemErrorCode());
   }
   return "";
 }