Browse Source

Use scoped policy for micro tasks

Cheng Zhao 8 years ago
parent
commit
103fea5cdf
2 changed files with 7 additions and 5 deletions
  1. 5 4
      atom/common/node_bindings.cc
  2. 2 1
      spec/chromium-spec.js

+ 5 - 4
atom/common/node_bindings.cc

@@ -169,10 +169,11 @@ node::Environment* NodeBindings::CreateEnvironment(
       context->GetIsolate(), uv_default_loop(), context,
       args.size(), c_argv.get(), 0, nullptr);
 
-  // Node turns off AutorunMicrotasks, but we need it in web pages to match the
-  // behavior of Chrome.
-  if (!is_browser_)
-    context->GetIsolate()->SetAutorunMicrotasks(true);
+  // Node uses the deprecated SetAutorunMicrotasks(false) mode, we should switch
+  // to use the scoped policy to match blink's behavior.
+  if (!is_browser_) {
+    context->GetIsolate()->SetMicrotasksPolicy(v8::MicrotasksPolicy::kScoped);
+  }
 
   mate::Dictionary process(context->GetIsolate(), env->process_object());
   process.Set("type", process_type);

+ 2 - 1
spec/chromium-spec.js

@@ -510,9 +510,10 @@ describe('chromium feature', function () {
         }).then((reader) => {
           reader.read().then((r) => {
             reader.cancel()
+            done()
           })
         }).catch(function (e) {
-          done()
+          done(e)
         })
       })
     })