Browse Source

avoid overriding type value of showMessageBox

deepak1556 10 years ago
parent
commit
0b780def24
2 changed files with 4 additions and 3 deletions
  1. 1 0
      .gitignore
  2. 3 3
      atom/browser/api/lib/dialog.coffee

+ 1 - 0
.gitignore

@@ -10,3 +10,4 @@ node_modules/
 *.xcodeproj
 *.swp
 *.pyc
+npm-debug.log

+ 3 - 3
atom/browser/api/lib/dialog.coffee

@@ -83,8 +83,8 @@ module.exports =
 
     options ?= type: 'none'
     options.type ?= 'none'
-    options.type = messageBoxTypes.indexOf options.type
-    throw new TypeError('Invalid message box type') unless options.type > -1
+    messageBoxType = messageBoxTypes.indexOf options.type
+    throw new TypeError('Invalid message box type') unless messageBoxType > -1
 
     throw new TypeError('Buttons need to be array') unless Array.isArray options.buttons
 
@@ -93,7 +93,7 @@ module.exports =
     options.detail ?= ''
     options.icon ?= null
 
-    binding.showMessageBox options.type,
+    binding.showMessageBox messageBoxType,
                            options.buttons,
                            [options.title, options.message, options.detail],
                            options.icon,