fix: emit window-all-closed after closing the window (#28913)

Co-authored-by: Jeremy Rose <[email protected]>

shell/browser/native_window.cc

@@ -423,11 +423,11 @@ void NativeWindow::NotifyWindowClosed() {
   if (is_closed_)
     return;
 
-  WindowList::RemoveWindow(this);
-
   is_closed_ = true;
   for (NativeWindowObserver& observer : observers_)
     observer.OnWindowClosed();
+
+  WindowList::RemoveWindow(this);
 }
 
 void NativeWindow::NotifyWindowEndSession() {

spec-main/api-app-spec.ts

@@ -1724,6 +1724,8 @@ describe('default behavior', () => {
   });
 
   describe('window-all-closed', () => {
+    afterEach(closeAllWindows);
+
     it('quits when the app does not handle the event', async () => {
       const result = await runTestApp('window-all-closed');
       expect(result).to.equal(false);
@@ -1733,6 +1735,17 @@ describe('default behavior', () => {
       const result = await runTestApp('window-all-closed', '--handle-event');
       expect(result).to.equal(true);
     });
+
+    it('should omit closed windows from getAllWindows', async () => {
+      const w = new BrowserWindow({ show: false });
+      const len = new Promise(resolve => {
+        app.on('window-all-closed', () => {
+          resolve(BrowserWindow.getAllWindows().length);
+        });
+      });
+      w.close();
+      expect(await len).to.equal(0);
+    });
   });
 
   describe('user agent fallback', () => {