Browse Source

fix: update node inspector api usage

deepak1556 6 years ago
parent
commit
089001bd92
1 changed files with 8 additions and 5 deletions
  1. 8 5
      atom/browser/node_debugger.cc

+ 8 - 5
atom/browser/node_debugger.cc

@@ -39,15 +39,18 @@ void NodeDebugger::Start() {
   auto options = std::make_shared<node::DebugOptions>();
   std::vector<std::string> exec_args;
   std::vector<std::string> v8_args;
-  std::string error;
+  std::vector<std::string> errors;
 
   node::options_parser::DebugOptionsParser::instance.Parse(
       &args, &exec_args, &v8_args, options.get(),
-      node::options_parser::kDisallowedInEnvironment, &error);
+      node::options_parser::kDisallowedInEnvironment, &errors);
 
-  if (!error.empty()) {
+  if (!errors.empty()) {
+    std::string error_str;
+    for (const auto& error : errors)
+      error_str += error;
     // TODO(jeremy): what's the appropriate behaviour here?
-    LOG(ERROR) << "Error parsing node options: " << error;
+    LOG(ERROR) << "Error parsing node options: " << error_str;
   }
 
   // Set process._debugWaitConnect if --inspect-brk was specified to stop
@@ -58,7 +61,7 @@ void NodeDebugger::Start() {
   }
 
   const char* path = "";
-  if (inspector->Start(path, options))
+  if (inspector->Start(path, options, true /* is_main */))
     DCHECK(env_->inspector_agent()->IsListening());
 }