Pchen0/electron

fix: submenu should be autoreleased (#25688)

Co-authored-by: Cheng Zhao <[email protected]>

trop[bot] 4 years ago

parent

e089cab8cd

commit

0667110350

1 changed files with 1 additions and 1 deletions

Split View Show Diff Stats

						
							+ 1
							
							- 1
						
shell/browser/ui/cocoa/electron_menu_controller.mm
							 
								View File
							
				@@ -297,7 +297,7 @@ static base::scoped_nsobject<NSMenu> recentDocumentsMenuSwap_;
			
				     [item setTarget:nil];
			
				     [item setAction:nil];
			
				-    NSMenu* submenu = [[NSMenu alloc] initWithTitle:label];
			
				+    NSMenu* submenu = [[[NSMenu alloc] initWithTitle:label] autorelease];
			
				     [item setSubmenu:submenu];
			
				     [NSApp setServicesMenu:submenu];
			
				   } else if (type == electron::ElectronMenuModel::TYPE_SUBMENU &&

fix: submenu should be autoreleased (#25688)

+ 1 - 1 shell/browser/ui/cocoa/electron_menu_controller.mm View File

+ 1 - 1
shell/browser/ui/cocoa/electron_menu_controller.mm
View File