Browse Source

chore: remove leftovers from memory property removal from app.getAppMetrics() (#18422)

Milan Burda 5 years ago
parent
commit
02e325d1ab
2 changed files with 0 additions and 24 deletions
  1. 0 12
      docs/api/structures/memory-info.md
  2. 0 12
      lib/browser/api/app.js

+ 0 - 12
docs/api/structures/memory-info.md

@@ -1,12 +0,0 @@
-# MemoryInfo Object
-
-* `pid` Integer - Process id of the process.
-* `workingSetSize` Integer - The amount of memory currently pinned to actual physical RAM.
-* `peakWorkingSetSize` Integer - The maximum amount of memory that has ever been pinned
-  to actual physical RAM. On macOS its value will always be 0.
-* `privateBytes` Integer - The amount of memory not shared by other processes, such as
-  JS heap or HTML content.
-* `sharedBytes` Integer - The amount of memory shared between processes, typically
-  memory consumed by the Electron code itself
-
-Note that all statistics are reported in Kilobytes.

+ 0 - 12
lib/browser/api/app.js

@@ -40,18 +40,6 @@ Object.assign(app, {
   }
 })
 
-const nativeFn = app.getAppMetrics
-app.getAppMetrics = () => {
-  const metrics = nativeFn.call(app)
-  for (const metric of metrics) {
-    if ('memory' in metric) {
-      deprecate.removeProperty(metric, 'memory')
-    }
-  }
-
-  return metrics
-}
-
 app.isPackaged = (() => {
   const execFile = path.basename(process.execPath).toLowerCase()
   if (process.platform === 'win32') {