Home Explore 引导页 在线工具 Blog
Register Sign In
Pchen0
/
electron
1
0
Fork 0
Files Issues 0 Pull Requests 0 Wiki
Browse Source

Add spec for render-view-deleted issue

Kevin Sawicki 8 years ago
parent
7a9a2c003c
commit
02dcc1bf3f
2 changed files with 47 additions and 0 deletions
Split View Show Diff Stats
  1. 15 0
      spec/api-ipc-spec.js
  2. 32 0
      spec/fixtures/api/render-view-deleted.html

+ 15 - 0
spec/api-ipc-spec.js
View File 

@@ -492,4 +492,19 @@ describe('ipc module', function () {
 
       assert.equal(w.listenerCount('test'), 0)
 
     })
 
   })
 
+
 
+  describe('remote objects registry', function () {
 
+    it('does not dereference until the render view is deleted (regression)', function (done) {
 
+      w = new BrowserWindow({
 
+        show: true
 
+      })
 
+
 
+      ipcMain.once('error-message', (event, message) => {
 
+        assert(message.startsWith('Cannot call function \'getURL\' on missing remote object'), message)
 
+        done()
 
+      })
 
+
 
+      w.loadURL('file://' + path.join(fixtures, 'api', 'render-view-deleted.html'))
 
+    })
 
+  })
 
 })

+ 32 - 0
spec/fixtures/api/render-view-deleted.html
View File 

@@ -0,0 +1,32 @@
 
+<!DOCTYPE html>
 
+<html>
 
+  <head>
 
+    <meta charset="utf-8">
 
+    <title></title>
 
+    <script>
 
+      const {ipcRenderer, remote} = require('electron')
 
+
 
+      const contents = remote.getCurrentWebContents()
 
+
 
+      // This should not trigger a dereference and a remote getURL call should not fail
 
+      contents.emit('render-view-deleted', {}, 'not-a-process-id')
 
+      try {
 
+        contents.getURL()
 
+      } catch (error) {
 
+        ipcRenderer.send('error-message', 'Unexpected error on getURL call')
 
+      }
 
+
 
+      // This should trigger a dereference and a remote getURL call should fail
 
+      contents.emit('render-view-deleted', {}, contents.getProcessId())
 
+      try {
 
+        contents.getURL()
 
+        ipcRenderer.send('error-message', 'No error thrown')
 
+      } catch (error) {
 
+        ipcRenderer.send('error-message', error.message)
 
+      }
 
+    </script>
 
+  </head>
 
+  <body>
 
+
 
+  </body>
 
+</html>